https://bugzilla.redhat.com/show_bug.cgi?id=1427341 --- Comment #37 from Charalampos Stratakis <cstratak@xxxxxxxxxx> --- Hello Vincent and thanks for continuing working on it. I currently replied to the legal mailing list as the license issue is not yet entirely clear. However I will proceed with the fedora-review tool so the review can move a bit forward. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 Note from reviewer: gcc is now required to be listed as a dependency. See: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B#BuildRequires_and_Requires ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Note from reviewer: The shared libraries are in /usr/lib64/python2.7/site-packages/gamera/ and upstream does not version them however they are required for runtime, thus they are not development .so files. They are also not included in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2)", "*No copyright* LGPL (v2 or later)", "LGPL (v2 or later)", "GPL (v2 or later)", "CC by-sa GPL", "Unknown or generated", "MIT/X11 (BSD like)", "NTP", "MIT/X11 (BSD like) NTP", "LGPL", "GPL (v2 or later) (with incorrect FSF address)". 295 files have unknown license. Note from reviewer: Still waiting on an answer from the legal mailing list. Thread here: https://lists.fedoraproject.org/archives/list/legal@xxxxxxxxxxxxxxxxxxxxxxx/thread/AB5S7LXEVXWR4VRKYGZO3MXHGFFZJAGO/ [x]: License file installed when any subpackage combination is installed. [?]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Note from reviewer: Still waiting on an answer from the legal mailing list [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. Note from reviewer: FPC involvement is not required anymore, see https://pagure.io/fesco/issue/1483 [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. Note from reviewer: Package should have a runtime requirement for wxPython as the gamera_gui binary needs it to run. If it's not present a traceback is shown. You should add: Requires: wxPython Right after the summary tag of the python2 subpackage. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. Note from reviewer: Documentation is not being built. It is not a blocker for the review and it's up to the packager if he wants to do it at some point in the future. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). Also proposing to add two additional provides tags as the package can also be considered an application. e.g. Provides: gamera = %{version}-%{release} and Provides: gamera%{?_isa} = %{version}-%{release} See also: https://fedoraproject.org/wiki/Packaging:Guidelines#Libraries_and_Applications [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. Note from reviewer: Did some initial testing and it imports successfully with python2. Also after installing the dependency on wxPython (see above)the binary works. Will need to do some more testing although it seems that the package is functional. Leaving this option as "not evaluated" till I conduct some more testing. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-gamera-3.4.3-5.fc27.x86_64.rpm python2-gamera-devel-3.4.3-5.fc27.x86_64.rpm python-gamera-debuginfo-3.4.3-5.fc27.x86_64.rpm python-gamera-3.4.3-5.fc27.src.rpm python2-gamera.x86_64: W: hidden-file-or-dir /usr/lib/.build-id python2-gamera.x86_64: W: hidden-file-or-dir /usr/lib/.build-id python2-gamera.x86_64: W: no-manual-page-for-binary gamera_gui python2-gamera-devel.x86_64: W: no-documentation <snip> Too many warnings for wrong address of FSF however they are coming from the bundled libraries. Requires -------- python2-gamera (rpmlib, GLIBC filtered): /usr/bin/python2 libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(GOMP_2.0)(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(OMP_1.0)(64bit) libgomp.so.1(OMP_2.0)(64bit) libm.so.6()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtiff.so.5()(64bit) libtiff.so.5(LIBTIFF_4.0)(64bit) python(abi) rtld(GNU_HASH) python-gamera-debuginfo (rpmlib, GLIBC filtered): python2-gamera-devel (rpmlib, GLIBC filtered): python(abi) python-gamera(x86-64) Provides -------- python2-gamera: application() application(python-gamera.desktop) python-gamera python-gamera(x86-64) python2-gamera python2-gamera(x86-64) python2.7dist(gamera) python2dist(gamera) python-gamera-debuginfo: python-gamera-debuginfo python-gamera-debuginfo(x86-64) python2-gamera-devel: python-gamera-devel python-gamera-devel(x86-64) python2-gamera-devel python2-gamera-devel(x86-64) Unversioned so-files -------------------- python2-gamera: /usr/lib64/python2.7/site-packages/gamera/gameracore.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/graph.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/kdtree.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/knncore.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/knnga.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_arithmetic.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_binarization.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_color.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_contour.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_convolution.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_corelation.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_deformation.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_draw.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_edgedetect.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_features.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_fourier_features.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_geometry.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_gui_support.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_image_conversion.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_image_utilities.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_listutilities.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_logical.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_misc_filters.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_misc_free_functions.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_morphology.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_pagesegmentation.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_png_support.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_projections.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_runlength.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_segmentation.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_string_io.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_structural.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_thinning.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_threshold.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_tiff_support.so python2-gamera: /usr/lib64/python2.7/site-packages/gamera/plugins/_transformation.so Source checksums ---------------- https://github.com/hsnr-gamera/gamera/releases/download/3.4.3/gamera-3.4.3.tar.gz : CHECKSUM(SHA256) this package : 02c194e95822e6f5499ddc4770ec5ad02ac613af274f31aa7ada158d657ac284 CHECKSUM(SHA256) upstream package : 02c194e95822e6f5499ddc4770ec5ad02ac613af274f31aa7ada158d657ac284 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1427341 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
