[Bug 1455886] Review Request: nuvola-app-amazon-cloud-player - Amazon Cloud Player for Nuvola Player 3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1455886

Vít Ondruch <vondruch@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #10 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
The build on Rawhide is failing for me:

~~~
RPM build errors:
    File not found:
/builddir/build/BUILDROOT/nuvola-app-amazon-cloud-player-5.4-5.fc27.x86_64/usr/share/icons/*/*/*/nuvolaplayer3_amazon_cloud_player.*
~~~

Is this since the issues:

https://github.com/tiliado/nuvola-app-amazon-cloud-player/issues/25
https://github.com/tiliado/nuvola-app-amazon-cloud-player/issues/26

were resolved? Removing the
"%{_datadir}/icons/*/*/*/nuvolaplayer3_amazon_cloud_player.*" line helps. Also,
the sed applied to Makefile si not necessary anymore, I guess.

Otherwise the package looks good => I APPROVE the package. Please fix the build
issues prior you import the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux