https://bugzilla.redhat.com/show_bug.cgi?id=1464778 Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |besser82@xxxxxxxxxxxxxxxxx --- Comment #2 from Björn "besser82" Esser <besser82@xxxxxxxxxxxxxxxxx> --- Some other hints on the spec-file: > URL: http://www.oletus.fi/static/whichwayisup/ > Source0: http://www.oletus.fi/static/whichwayisup/%{name}_b%{pkgversion}.zip URL should NOT end with a trailing slash '/') and you can shorten and simplify those really good using: URL: http://www.oletus.fi/static/${name} Source0: %{url}/%{name}_b%{pkgversion}.zip > %setup -qn %{name} > %patch0 -p1 Using the `autosetup`-macro is preferred (and support since el5) for new packages. It supports automatic patching and all: %autosetup -p 1 > install -d %{buildroot}%{_bindir} > install -m 755 -p %{SOURCE1} %{buildroot}%{_bindir}/%{name} This applies to most of the code using `install`. You can do all of this in one line and mode SHOULD be set in four-digit octal (e.g. 0755 / 0644): install -Dpm 0755 %{SOURCE1} %{buildroot}%{_bindir}/%{name} > %{_mandir}/man6/* Should be: %{_mandir}/man6/%{name}.6* I'm not too happy with the wrapper script… You shouldn't install that from a static file as is… Instead you should auto-generate that from inside the spec-file (don't forget to have BR: python2-devel): %{__cat} << EOF > %{buildroot}%{_bindir}/%{name} #!/bin/sh set -e pushd %{_datadir}/%{name} %{__python2} -s run_game.py "$@" popd EOF At last I'd recommend using rpm-defined macros instead of plain command invocation (my personal preference, left open to you): * %{__sed} instead of `sed` * %{__install} instead of `install` * %{__cp} instead of `cp` * %{__mkdir_p} instead of `mkdir -p` * %{__rm} instead of `rm` * %{__ln_s} instead of `ln -s` *** Spec-file and srpm are no direct downloads: $ fedora-review -m fedora-rawhide-x86_64 -b 1464778 ; INFO: Processing bugzilla bug: 1464778 INFO: Getting .spec and .srpm Urls from : 1464778 INFO: --> SRPM url: https://svgames.pl/fedora/whichwayisup-0.7.9-1.src.rpm INFO: --> Spec url: https://www.dropbox.com/sh/46vz8vz5rmxx0ac/AADLlEEIDcFazfpKuVQJcs53a/reviews/whichwayisup.spec INFO: Using review directory: /home/besser82/vm_shared/fedora/review/1464778-whichwayisup INFO: Downloading .spec and .srpm files error: line 1: Unknown tag: <!DOCTYPE html><html lang="en" xmlns:fb="http://ogp.me/ns/fb#"; xml:lang="en" class="maestro" xmlns="http://www.w3.org/1999/xhtml";> ERROR: "Can't parse specfile: can't parse specfile\n" (logs in /home/besser82/.cache/fedora-review.log) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
