Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: sundials - nonlinear differential/algebraic solvers from LLNL https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249034 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-07-31 14:38 EST ------- Well, * /sbin/ldconfig call - calling /sbin/ldconfig is not needed for -devel package * static archive - split static archives from -devel package, move them to -static subpackage and make -static subpackage require -devel subpackge (check: Packaging Static Libraries of http://fedoraproject.org/wiki/Packaging/Guidelines ) * dependency for main/subpackage - Usually the dependency for main/subpackage must be version-release specific i.e. -devel package must have: "Requires: %{name} = %{version}-%{release}" * defattr - We recommend %defattr(-,root,root,-) - Also this must be added to all subpackages. (In reply to comment #19) > Mamoru, feel free to let me know if I have slipped up somewhere. > Since this is > my first review, your help might be useful. Well, when you want to review in this style, please also write the summary of where to fix so that your review can be read easily. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review