https://bugzilla.redhat.com/show_bug.cgi?id=1450590 James Hogarth <james.hogarth@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |asymptotically508@xxxxxxxxx Flags| |needinfo?(asymptotically508 | |@gmail.com) --- Comment #12 from James Hogarth <james.hogarth@xxxxxxxxx> --- So the FPC agree the wording needs to be cleaned up, but the way the libraries are handled in watchman complies with policy :) So the only things that need to be cleared up IIRC are: - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: watchman-2.spec should be watchman.spec See: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Spec_file_name - Directory /usr/share/doc/watchman-4.7.0 is not owned - Either use %doc and let it copy over to the right location or set %doc at the start of the path to where documentation is installed, don't do both in %files - The v in %changelog should not be there, only the number eg 4.7.0-3 not v4.7.0-3 - %install must not have the rm -rf line - The spec in your review must match the spec in the srpm for the review If you can please update with that sorted out I'll be able to approve the package, and then do a quick review of your informal reviews and if all good get you in the packagers group :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
