https://bugzilla.redhat.com/show_bug.cgi?id=1462443 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags| |fedora-review+ --- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- + license is acceptable for Fedora (BSD) + license is specified correctly (there are some GPL and MIT/X11 files, but those are build scripts) + package name is OK + builds and install fine + R/P/BR look correct + scriptlets are sane + %check is present and passes So the only non-trivial thing is the patent situation. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Patented_Software says that a written license grant is necessary. https://gitlab.dkrz.de/k202009/libaec/blob/master/doc/patent.txt#L44 is such a license grant, so it seems OK to include this in Fedora. > NASA cannot warrant [...] that your use will not infringe on another's intellectual property rights. Right. But that's always true, for any software, and seems to be a standard disclaimer that doesn't mean anything except that NASA allows use of the algorithm, without making any promises on behalf of other parties. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
