https://bugzilla.redhat.com/show_bug.cgi?id=1439894 Petr Oros <poros@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(poros@xxxxxxxxxx) | --- Comment #6 from Petr Oros <poros@xxxxxxxxxx> --- Hi, Latest version: https://github.com/orosp/ddiskit/archive/3.4.tar.gz Fixed Issues: - move scripts from %{python_sitelib} to /usr/share/ddiskit - create man page - binary should have man page - mark ddiskit.bash as config with %config(noreplace) - if you have new directories in %files section, you need to define it before using with %dir - f.e. %dir %{datadir}/%{srcname} - where you are using "ddiskit" in spec, you can use %{srcname} - it is more general solution - empty files 'default' and 'rh-release' in 'profiles' directory - delete them or add into them some comments like "This file is for..." - no need for %{srcname} global macro - you should use %{name} macro dependency on kernel-devel - is it necessary? ----> YES Many thanks, -Petr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
