https://bugzilla.redhat.com/show_bug.cgi?id=1462682 Kalev Lember <klember@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Kalev Lember <klember@xxxxxxxxxx> --- Fedora review libdazzle-3.25.3-1.fc27.src.rpm 2017-06-22 $ rpmlint libdazzle-3.25.3-1.fc27.src.rpm \ libdazzle \ libdazzle-debuginfo \ libdazzle-devel libdazzle.x86_64: W: no-manual-page-for-binary dazzle-list-counters libdazzle-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 2 warnings. + OK ! needs attention + rpmlint warnings are harmless and can be ignored + The package is named according to Fedora packaging guidelines + The spec file name matches the base package name. + The package meets the Packaging Guidelines + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The license field in the spec file matches the actual license + The license text (COPYING) is included in %license + Spec file is written in American English + Spec file is legible + Upstream sources match the sources in the srpm 6fc3f7d6ec2aaa57f2500004c9763b0ec432f5269f5f74cc91a3da52d7bc6cf809893be6c0176495ffe309647af4efd1a22243bbd5b265846c301ce1d9d98d47 libdazzle-3.25.3.tar.xz 6fc3f7d6ec2aaa57f2500004c9763b0ec432f5269f5f74cc91a3da52d7bc6cf809893be6c0176495ffe309647af4efd1a22243bbd5b265846c301ce1d9d98d47 Download/libdazzle-3.25.3.tar.xz ! A rawhide scratch build failed, https://koji.fedoraproject.org/koji/taskinfo?taskID=20091619 -- looks like an error building docs. It builds fine on f26 though. Possibly caused by something that has changed on rawhide? n/a ExcludeArch bugs filed + BuildRequires look sane + locale handling + ldconfig in %post and %postun + Package does not bundle copies of system libraries n/a Package isn't relocatable + Package owns all the directories it creates + No duplicate files in %files + Permissions are properly set + Consistent use of macros + The package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect the runtime of application n/a Static libraries should be in -static + Development files should be in -devel + -devel must require the fully versioned base + Packages should not contain libtool .la files n/a Proper .desktop file handling + Doesn't own files or directories already owned by other packages + Filenames are valid UTF-8 Looks nice and clean. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
