Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Mapnik cartography library - first package, need sponsor. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234581 ------- Additional Comments From kms@xxxxxxxxxxxxxx 2007-07-31 12:12 EST ------- > Some files have Windows-style end-of-file encodings. Please fix them > to Unix-style encodings Files removed in upstream SVN. > Summary should not end with dot. Fixed. > QUESTION How is libmapnik.so used? > - Is this library used only by this package? > - Or can this library be linked from other software? Still waiting on upstream. > - In %changelog, please use %%_prefix. Otherwise %_prefix is expanded > in %changelog. Fixed. > * compilation flags > - Fedora specific compilation flags are not honored. > - -O3 flag is generally forbidden (this make debugging difficult) Fixed in SPEC file / patches. Upstream did not want to change. > * Fonts > - Fedora has dejavu-fonts, dejavu-fonts-experimental and > shipping duplicate dejavu fonts in this package is not > allowed. Fixed in SPEC file / patches. Still needed in upstream to build on other platforms (eg Windows). > * sitelib vs sitearch > - This package installs > /usr/lib/python2.5/site-packages/mapnik/_mapnik.so , > which is arch dependent. > python related files must be installed under %python_sitearch. > not under %python_sitelib. Fixed. I am still waiting on upstream to fix the soversion and then to make a release. I have not published an updated version of my SPEC file as I have switched to building from SVN prior to the upstream release. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review