https://bugzilla.redhat.com/show_bug.cgi?id=1460317 --- Comment #6 from Fabio Valentini <decathorpe@xxxxxxxxx> --- There are only a few minor issues left: Blocking positive review: 6) The license tag is still incorrect - according to licensecheck / fedora-review, no GFDL licensed files are present in the tarball. 10) Move "Requires(post): hicolor-icon-theme" to "Requires: hicolor-icon-theme". Otherwise, the created icon directories will be unowned. 23) Remove the autoreconf invocation in %prep. This step is superfluous when building from release tarballs. 35) The installed gnome-panel.desktop entry MUST be validated in %check: %check desktop-file-validate $RPM_BUILD_ROOT/%{_datadir}/applications/*.desktop || : 42) The "Requires: %{name}-libs = %{version}-%{release}" tag is missing the %{?_isa} macro in the -devel subpackage. Non-blocking issues: 1) Consider putting "https://wiki.gnome.org/Projects/GnomePanel"; as the URL (as that is the GNOME panel project's homepage). 20) Description lines are still longer than 72 characters (though this is not a blocker). 25) Use the modern %make_build macro instead of "make %{?_smp_mflags} V=1". 27) Use the modern %make_install macro instead of "make DESTDIR=$RPM_BUILD_ROOT install". 29) Use a less broad pattern to remove *.la files (other files with extensions ending in "a" are removed right now, too). "find $RPM_BUILD_ROOT -name '*.la' -delete -print" 30) Remove the commented FIXME in %install. 32) Sorted %files and BuildRequires would be nice. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
