https://bugzilla.redhat.com/show_bug.cgi?id=1389404 --- Comment #5 from Athos Ribeiro <athoscribeiro@xxxxxxxxx> --- Hi David, - Upstream already ships a LICENSE file [1], you should use it (no need to contact upstream). - For the python2- subpackage, you want to use the python2-* Requires and BR, not just python-* (they are already available for your dependencies). - The licence file you are shipping in python2 and python3 subpackages belongs to the documentation theme: it should go in the documentation subpackage instead, not in the binary packages. - You are removing the tests directory in %build, so there's no tests to run in %check. - There are (still) some import errors being raised while building documentation, did you check that [2]? [1] https://github.com/dcrosta/flask-pymongo/blob/master/LICENSE [2] Executing(%build): /bin/sh -e /var/tmp/rpm-tmp.tEhIGH ... + sphinx-build docs html ... looking for now-outdated files... /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:59: WARNING: autodoc: failed to import method u'Collection.find_one_or_404' from module u'flask_pymongo.wrappers'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:61: WARNING: autodoc: failed to import method u'PyMongo.send_file' from module u'flask_pymongo'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:63: WARNING: autodoc: failed to import method u'PyMongo.save_file' from module u'flask_pymongo'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:65: WARNING: autodoc: failed to import class u'BSONObjectIdConverter' from module u'flask_pymongo'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:193: WARNING: autodoc: failed to import data u'ASCENDING' from module u'flask_pymongo'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:195: WARNING: autodoc: failed to import data u'DESCENDING' from module u'flask_pymongo'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:201: WARNING: autodoc: failed to import class u'PyMongo' from module u'flask_pymongo'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:204: WARNING: autodoc: failed to import class u'Collection' from module u'flask_pymongo.wrappers'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:217: WARNING: autodoc: failed to import class u'MongoClient' from module u'flask_pymongo.wrappers'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:220: WARNING: autodoc: failed to import class u'MongoReplicaSetClient' from module u'flask_pymongo.wrappers'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors /builddir/build/BUILD/Flask-PyMongo-0.5.1/docs/index.rst:223: WARNING: autodoc: failed to import class u'Database' from module u'flask_pymongo.wrappers'; the following exception was raised: Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/sphinx/ext/autodoc.py", line 551, in import_object __import__(self.modname) File "/builddir/build/BUILD/Flask-PyMongo-0.5.1/flask_pymongo/__init__.py", line 29, in <module> from bson.errors import InvalidId ImportError: No module named bson.errors none found -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
