https://bugzilla.redhat.com/show_bug.cgi?id=1455886 --- Comment #7 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Build issues - It seems that you need to add BR on python3-six to fix the build. I think the issue is caused by this [1] commit. - BTW the same commit breaks Diorite [2]. The python3-pyparsing should be required unconditionally everywhere. I still don't understand what was the difference between f26/f27, that it was not needed, but it probably does not matter anyway ... * nuvolaruntime-devel dependency. - Why is there the nuvolaruntime-devel BR? It does not appear to be required. * Wrong "extends" tag in .metainfo.xml - The "extends" tag should reference the "nuvolaruntime" desktop file, right [3]? * Are the nuvolaplayer3_amazon_cloud_player.* icons required? - I am not sure the icons located in %{_datadir}/icons/*/*/* /nuvolaplayer3_amazon_cloud_player.* are required. The .desktop file specifies they should be named eu.tiliado.NuvolaAppAmazonCloudPlayer, which is the other set available. This should be probably discussed with upstream. - BTW rpmlint complains about these files: ~~~ nuvola-app-amazon-cloud-player.noarch: W: dangling-relative-symlink /usr/share/icons/hicolor/128x128/apps/nuvolaplayer3_amazon_cloud_player.png ../../../../nuvolaplayer3/web_apps/amazon_cloud_player/icons/128.png ~~~ * Missing requires - The package specifies no requires, but it definitely needs nuvola runtime, so it should probably specify the dependency: ~~~ Requires: %{_bindir}/nuvola ~~~ [1] http://pkgs.fedoraproject.org/cgit/rpms/python-setuptools.git/commit/?id=5e5ba5a5931b254843baaf45e6dbd1ebe2769b91 [2] https://apps.fedoraproject.org/koschei/package/diorite?collection=f27 [3] https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Addon.html#tag-extends -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
