https://bugzilla.redhat.com/show_bug.cgi?id=1441798 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > BuildRequires: python Shouldn't this by python2 or python3 instead? If any version is OK, maybe add a comment. Url, Source0: http → https. - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. I think this applies to .desktop files in /usr/share/kservicetypes5/ too. It should be validated. rpmlint: kreport.x86_64: W: incoherent-version-in-changelog 3.0.1-0.1 ['3.0.1-1.fc27', '3.0.1-1'] Please fix. kreport.x86_64: W: no-documentation kreport.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kreport.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kreport-devel.x86_64: W: only-non-binary-in-usr-lib kreport-devel.x86_64: W: no-documentation All OK. 4 packages and 0 specfiles checked; 0 errors, 6 warnings. + package name is OK + licence is acceptable for Fedora (LGPLv2+) + license is specified correctly + builds and installs OK + P/R/BR look correct (some Requires might be trimmed possibly) + scriptlets follow the guidelines + fedora-review finds no issues apart from the desktop file validation Looks all good, apart from some minor issues which can be fixed when importing. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
