https://bugzilla.redhat.com/show_bug.cgi?id=1441804 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- > BuildRequires: python Shouldn't this by python2 or python3 instead? If any version is OK, maybe add a comment. > # sqlite driver included in base (for now) > %{_qt5_plugindir}/kdb3/kdb_sqlitedriver.so Maybe add Provides: %{name}-driver-sqlite%{?_isa} = %{name}-%{version} so that it's easier to split out in the future? (Other packages can use R:%{name}-driver-sqlite w/o worrying about the potential future split.) http://community.kde.org/KDb → https:// http://download.kde.org/stable/ → https:// + package name is OK + licence is acceptable for Fedora (LGPLv2+) + license is specified correctly (docs seems to have a different license, but they're not in any of the binary packages, so irrelevant.) + builds and installs OK + P/R/BR look correct + scriptlets follow the guidelines + fedora-review finds no issues I didn't test the upgrade paths, but the Provides/Obsoletes seems all good. Rpmlint (installed packages) ---------------------------- kdb-driver-postgresql.x86_64: W: obsolete-not-provided koffice-kexi-driver-pgsql kdb.x86_64: W: obsolete-not-provided calligra-kexi-driver-sybase kdb.x86_64: W: obsolete-not-provided calligra-kexi-driver-xbase kdb-driver-mysql.x86_64: W: obsolete-not-provided koffice-kexi-driver-mysql OK. kdb-driver-postgresql.x86_64: W: no-documentation kdb-driver-postgresql.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kdb-driver-postgresql.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kdb-devel.x86_64: W: only-non-binary-in-usr-lib kdb-devel.x86_64: W: no-documentation kdb.x86_64: W: no-documentation kdb.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kdb.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kdb.x86_64: W: no-manual-page-for-binary kdb3_sqlite3_dump kdb-driver-mysql.x86_64: W: no-documentation kdb-driver-mysql.x86_64: W: hidden-file-or-dir /usr/lib/.build-id kdb-driver-mysql.x86_64: W: hidden-file-or-dir /usr/lib/.build-id All OK. kdb.x86_64: W: incoherent-version-in-changelog 3.0.1-0.1 ['3.0.1-1.fc27', '3.0.1-1'] Please fix. kdb.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKDb3.so.3.0 /lib64/libm.so.6 kdb.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libKDb3.so.3.0 /lib64/libgcc_s.so.1 kdb.x86_64: W: shared-lib-calls-exit /usr/lib64/libKDb3.so.3.0 exit@GLIBC_2.2.5 Might be worth cleaning up at some point... 5 packages and 0 specfiles checked; 0 errors, 20 warnings. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
