https://bugzilla.redhat.com/show_bug.cgi?id=1462760 Rex Dieter <rdieter@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter <rdieter@xxxxxxxxx> --- scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=20065556 $ rpmlint ./gir-to-d-0.10.0-1.fc25.x86_64.rpm gir-to-d.x86_64: W: spelling-error %description -l en_US typelib -> type lib, type-lib, Teletype gir-to-d.x86_64: E: non-standard-executable-perm /usr/bin/girtod 775 gir-to-d.x86_64: W: no-manual-page-for-binary girtod 1 packages and 0 specfiles checked; 1 errors, 2 warnings. 1. permissions, as noted by rpmlint, /usr/bin/girtod 775 is a little surprising and non-standard (compared to expected 755), please confirm this is purposeful and needed. Otherwise, use 755. naming: ok sources: ok 5620b303fb174626bee2f7a2ea4e698f gir-to-d-0.10.0.tar.gz license: ok macros: ok (mostly). I'd argue that ideally workarounds like: -------------- export DFLAGS="%{_d_optflags}" # Drop '-specs=/usr/lib/rpm/redhat/redhat-hardened-ld' as LDC doesn't support it export LDFLAGS="-Wl,-z,relro" -------------- should be handled automatically elsewhere (like ldc or macros.ldc), so all consumer apps/pkgs would not have to include such workarounds. scriptlets: n/a otherwise, .spec is fairly simple and clean. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
