[Bug 1460630] Review Request: copr-rpmbuild - performs COPR builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1460630

Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jkadlcik@xxxxxxxxxx



--- Comment #2 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
> Version: 0.2

As noted in previous comment, there is already a 0.3 version


> Summary: Run COPR build tasks
> Name: copr-rpmbuild

It is not wrong or forbidden but can we swap the lines, so Name is first?


> install -d %{buildroot}%{_sysconfdir}/copr-rpmbuild
> install -d %{buildroot}%{_sharedstatedir}/copr-rpmbuild
> install -d %{buildroot}%{_sharedstatedir}/copr-rpmbuild/results

There are lot of lines like this. Maybe it would be better to use %{name}
instead of typing the copr-rpmbuild over and over again?


> copr-rpmbuild.noarch: W: no-url-tag

Please add `Url:` tag with link to upstream URL


> copr-rpmbuild.noarch: E: wrong-script-interpreter /usr/bin/copr-rpmbuild /usr/bin/env perl

AFAIK we should not use /usr/bin/env, but rather use e.g. /usr/bin/perl


> %description
> Provides command capable of running COPR build-task definitions.

Don't consider it as necessary, but I would like to see more information. I've
heard about this package on meetings and yet I hardly know what exactly it
does. I can imagine that people with no previous knowledge will not understand
it from such description either.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux