https://bugzilla.redhat.com/show_bug.cgi?id=1460917 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@xxxxxxxxxx --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- > Name: rpkg Name of the package conflicts with already existing package. https://admin.fedoraproject.org/pkgdb/package/rpms/rpkg/ May I suggest naming it rpkg-client as the upstream project names? > BuildRequires: python-rpkg > Requires: python-rpkg There is no such package `python-rpkg`. Maybe you meant `python2-rpkg`? > %if 0%{?fedora} >= 26 > ... > %else > BuildRequires: pyrpkg > Requires: pyrpkg python2-rpkg-1.49-3 which is even for F25 obsoletes pyrpkg < 1.49-2 > %description > DistGit command-line client. Can you please change the description text so it is not just a duplicate of summary line? I would also prefer more descriptive text. Using description from the first comment in this BZ would be probably sufficient. > Rpmlint > ------- > Checking: rpkg-0.2-1.fc27.noarch.rpm > rpkg-0.2-1.fc27.src.rpm > rpkg.noarch: W: non-conffile-in-etc /etc/bash_completion.d/rpkg.bash Can you please mark the file as %config? %config(noreplace) %{_sysconfdir}/bash_completion.d/rpkg.bash -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
