https://bugzilla.redhat.com/show_bug.cgi?id=1460317 --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- That's why I wrote "where appropriate", because some of those points are only my opinion on how the "best possible" .spec file would look like, and not enforcible guidelines. However, I only pointed out things that make the current .spec file prone to errors and/or hard to read by a human, and most of them are (I think) reasonable suggestions or even necessary requirements for improvements. I admit that I am a bit pedantic when it comes to clarity and readability, so if you object to specific points I made and provide reasoning for why you are doing it the way it's done right now, I won't block the review on those points. Also, it seems I forgot to add two things to my list above: 41) Use %global instead of %define. 42) Fix present bogus dates in the %changelog. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
