https://bugzilla.redhat.com/show_bug.cgi?id=1460317 --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- There seems to be a LOT of outdated cruft in the .spec file. 1) The URL tag is pointing at the GNOME homepage, not a GNOME Panel page. 2) Don't use the Group: tag. 3) Remove the commented VCS: tag. 4) Use the %{name} macro in the Source0: tag consistently. 5) Remove the commented Patch0. 6) It seems GPLv2+ and LGPLv2+ for the main package and LGPLv2+ for the -libs subpackage are the correct licenses now (no more GFDL). 7) Is the explicit Requires: gnome-desktop3 necessary (libgnome-desktop* is pulled in automatically). 8) Remove the explicit Requires: libwnck3 (this is pulled in automatically). 9) Remove the explicit Requires: e-d-s (this is pulled in automatically). 10) Move Requires(post): hicolor-icon-theme to Requires: hicolor-icon-theme. 11) Remove Requires(*): GConf2. 12) Remove BR: GConf2-devel. 13) Move BR: foo-devel to pkgconfig(foo) where possible. 14) Remove BR: libXt-devel (looks like it's no longer needed). 15) Remove the duplicate BR: dconf-devel. 16) Remove BR: libXau-devel (looks like it's no longer needed). 17) Remove BR: telepathy-glib-devel (looks like it's no longer needed). 18) Remove the duplicate BR: libtool. 19) Remove outdated Obsoletes (these were generated on fedora 15, so they're obviously no longer relevant). 20) Wrap description lines at 72 characters. 21) Confirm that the package descriptions are accurate. 22) Use %autosetup to replace the whole %setup line. 23) Remove the suspicious steps in %prep. 24) Either enable building gtk-doc's or remove the unnecessary BRs. 25) Use the %make_build macro instead of "make %{?_smp_mflags} V=1". 26) Why are you truncating NEWS? It would be easier to just not ship it as %doc. 27) Use the %make_install macro instead of "make DESTDIR=$RPM_BUILD_ROOT install" 28) Is the removal of the scrollkeeper directory still necessary? 29) Are there even *.a files installed anymore? Are *.la files present? 30) Possibly remove commented FIXME in %install. 31) Remove glib-compile-schemas scriptlets from %post, %postun and %posttrans (they are obsolete). 32) Please sort the entries in %files alphabetically (if possible, by the actual values of the macros, not by the macro names. so, %{_libdir} is sorted before %{_datadir}). This makes it much easier to read. 33) Use a glob for the different icon directories (%{_datadir}/icons/hicolor/*/apps/gnome-panel*). 34) Mark owned directories with a trailing backslash so it's clear it's an owned directory and not an owned file (e.g. %{_datadir}/gnome-panel/). 35) The installed gnome-panel.desktop entry must be validated in %check (or, worse, at the end of %install) - to temporarily ignore errors, append " || :" at the end of the line containing the "desktop-file-validate" command. 36) Just own "%{_libdir}/gnome-panel/", no need to specify all contents by hand. 37) Use a glob for the glib schema xml files (%{_datadir}/glib-2.0/schemas/org.gnome.gnome-panel.*.xml). 38) Do NOT use a glob for the .so* files in %{_libdir}. 39) Since you're not building gtk-docs, don't include COPYING-DOCS and don't own the /usr/share/gtk-doc directory (or build gtk-docs). 40) Mark COPYING and COPYING.LIB as %license, not %doc. Either fix all those things (where appropriate), or just start fresh with a new .spec file without all the cruft. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
