[Bug 1457714] Review Request: plymouth-kcm - KCM for setting plymouth theme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1457714



--- Comment #4 from Jan Grulich <jgrulich@xxxxxxxxxx> ---
1) Why don't you use %find_lang? Also listing all localization as you did in
%files is not how usually this is done. 

2) This "%{_libdir}/qt5/plugins/kcms/kcm_plymouth.so" can be replaced with
%{_kf5_qtplugindir} if I'm not mistaken, also __provides_exclude_from should
point to that location.

3) + %postun /sbin/ldconfig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux