https://bugzilla.redhat.com/show_bug.cgi?id=1459693 Christos Triantafyllidis <christos.triantafyllidis@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(christos.triantaf | |yllidis@xxxxxxxxx) | --- Comment #5 from Christos Triantafyllidis <christos.triantafyllidis@xxxxxxxxx> --- Hello Carl, The updated .spec looks good to me. Same applies for the justification for the lack of the log rotating. The only remaining point for me is the log file permissions. I'd say let's wait 1-2 days for the upstream to conclude on whether 750 is needed or not. Looks like there is a PR now to make them world readable but some comments (with which I'd agree) to not :). If the upstream decision is to have them world readable I'd say we'll have to wait upstream to merge this change or patch this in the .spec to avoid changing the permissions later in the package's lifecycle. I'll revisit this and the upstream issues in the next days. Cheers, Christos -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
