[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=821406



--- Comment #54 from Raphael Groner <projects.rg@xxxxxxxx> ---
(In reply to Vasiliy Glazov from comment #53)
> 1. I should make this?
> License:        GPLv3+ and LGPLv2+ and BSD

I fail to see why LGPLv2+ is needed. All kinds of mentioned GPL versions of the
source files can be merged into GPLv3+. Please ensure that BSD is also noted as
we've some files licensed with different BSD variants.
It's necessary to add "BSL" or "Boost" (boost license) as well. Sorry, I've
overlooked that, it's all mentioned in the summary of f-r:

[!]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "GPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
     generated", "BSL (v1.0)", "BSD (3 clause) GPL (v3 or later)", "BSD (3
     clause)", "BSD (2 clause)", "GPL (v2.1) LGPL (v2.1)", "*No copyright*
     GPL (v2 or later)", "GPL (v2)", "*No copyright* GPL (v3 or later)",
     "*No copyright* GPL (v2)". 1203 files have unknown license. Detailed
     output of licensecheck in /home/builder/fedora-
     review/821406-eiskaltdcpp/licensecheck.txt

https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses

> 2. If I run eiskaltdcpp-qt it start with my (russian) locale. What do you mean
> about "locales for the qt subpackage"?

Okay, thanks for clarification. It was somehow confusing.

> 4. Requires: perl will be added.

Thanks.

> 5. Noarch subpackage will be created.

Thanks.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux