[Bug 1460662] Review Request: rubygem-mustermann - A library using patterns like regular expressions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1460662



--- Comment #4 from Jun Aruga <jaruga@xxxxxxxxxx> ---
Vit, thank you for the review.

I fixed those items that you mentioned.


1 point.

> ~~~
> %setup -q -D -T -n  %{gem_name}-%{version} -b1 -b2
> ~~~

Below "-b n" looks better regarding the official document' sample.

~~~
%setup -q -D -T -n  %{gem_name}-%{version} -b 1 -b 2
~~~

http://ftp.rpm.org/max-rpm/s1-rpm-inside-macros.html
> %setup -T -b 0


I updated below files.

Spec URL:
https://pagure.io/jaruga_rubygem-mustermann/raw/master/f/rubygem-mustermann.spec
SRPM URL:
https://pagure.io/jaruga_rubygem-mustermann/raw/master/f/rubygem-mustermann-1.0.0-1.fc27.src.rpm


Could you check again?
Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux