https://bugzilla.redhat.com/show_bug.cgi?id=1460662 --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- * Summary/Description - I'd say that the summary is misleading. The original (but capitalized) would be better IMHO. - The description should start with capital letter. * Group tag is deprecated - Please remove the Group tag. It is deprecated [1]. * Test {support,mustermann-contrib} libraries - It would be good to document why the {support,mustermann-contrib} is needed (e.g. "Support routines required by test suite"). - I don't think there is any reason to expand these libraries into the .%{gem_instdir}. Although we are using this on several places, this is used typically to mimic the upstream repository layout. In this case, I think it would be much better to expand the sources using the %setup macro in %prep section, e.g.: ~~~ %setup -q -D -T -n %{gem_name}-%{version} -b1 -b2 ~~~ * Idiomatic test suite execution. - We typically execute the RSpec test suite via "rspec spec". If you need to specify additional path, the "rspec" command supports -I variable just as ruby does. E.g. this should work for you: ~~~ rspec -I{support,mustermann-contrib}/lib spec ~~~ [1] https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
