https://bugzilla.redhat.com/show_bug.cgi?id=1460515 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- + package name is OK (I'd prefer a dash instead of the underscore, but upstream seems to use an underscore consistently, and both are allowed by the guidelines…) + license is acceptable for Fedora (ASL 2.0) + license is specified correctly (according to setup.py and LICENSE file) + builds and installs w/o issues + fedora-review find no issues (false positive about URL and a diff in comment between the linked spec file and srpm) + R/P/BR look correct + mypy loads this module correctly when the rpm is installed (it doesn't work, but I think that's a separate bug, I'll follow up elsewhere). Package is APPROVED. My only suggestion would be to change the Summary to not suggest that this module works under Python 2, and also to not suggest that it only supports type comments, since it also supports the new not-comment-based syntax in Python 3.6. Maybe something like "Summary: A fork of the ast module with support for type annotations, %description: %summary. This package is based on the ast modules from Python 2 and 3, and has been extended with support for type comments and type annotations as supported in Python 3.6.". Also, module names _ast3 and _ast27 are rather dangerous. It'd have been much better if they put them underneath their own namespace, as typed_ast._ast3 and typed_ast._ast27, but that that's an upstream issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
