https://bugzilla.redhat.com/show_bug.cgi?id=1458580 --- Comment #4 from Shawn Iwinski <shawn@xxxxxxxx> --- (In reply to Remi Collet from comment #3) > [!]: Latest version is packaged. > > cilex 1.1.0 => ok packager choise > console-service-provider 1.0.0 => ok for consistency (pimple v1 vs v2) FYI: cilex 1.1.0 b/c required by phpdoc v2 > [!]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > > => please file a upstream bug as even the latest version don't have it I did not do this because v1 is an older version of the lib. v2 does have a license file: https://github.com/Cilex/Cilex/blob/2.0.0/LICENSE > [!]: Final provides and requires are sane (see attachments). > > => missing php-composer(cilex/console-service-provider) bundled(php-cilex-console-service-provider) is provided. Since the lib is bundled, do we really want to provide php-composer(cilex/console-service-provider)? > [!]: Requires correct, justified where necessary. > > => php-tokenizer not needed > (only used by Compiler.php which is not packaged) Will remove after initial import if item above (provides) is deemed not necessary or will remove when I do make that change. > 3rd one is a blocker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
