https://bugzilla.redhat.com/show_bug.cgi?id=1460246 Iwicki Artur <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Iwicki Artur <fedora@xxxxxxxxxx> --- >Patch1: lua_package.patch While the patch itself is rather straight-forward, it'd still be nice to have a short comment in the spec file explaining what it does. >Summary: (...) done. >Group: Applications/Productivity The Summary should not end with a dot and the Group tag should not be used at all. https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections >make -j I believe you should use the %{?_smp_mflags} macro here (it expands to the -j option). >make install PREFIX=$RPM_BUILD_ROOT/usr Use the %{_prefix} macro instead of "/usr". >%_mandir/man1/wordgrinder.1.gz You should not assume that gzip will be used for compressing manpages - instead, use a pattern that can match both compressed and non-compressed files. https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages >* Wed Jun 07 2017 Ben Cotton <bcotton@xxxxxxxxxxxxxxxxx> - 0.6-1 Probably a typo in the domain name ("porject" instead of "project"). Also, there are some rpmlint errors: wordgrinder.x86_64: E: explicit-lib-dependency libXft wordgrinder.x86_64: E: explicit-lib-dependency zlib wordgrinder.x86_64: E: summary-too-long -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
