https://bugzilla.redhat.com/show_bug.cgi?id=1426193 Michael Scherer <misc@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #33 from Michael Scherer <misc@xxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - Avoid bundling fonts in non-fonts packages. The documentation bundle fonts. However, this is likely normal. - The %check in # Test dependencies for %check could cause trouble in the future (since rpm would expand the macro. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache (v2.0)", "*No copyright* Apache", "Unknown or generated", "*No copyright* Apache (v2.0)". 80 files have unknown license. Detailed output of licensecheck in /tmp/fr/1426193-ara/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/systemd/system, /etc/logrotate.d, /usr/lib/systemd [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 71680 bytes in 7 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2-ara , python3-ara , ara-common , ara-doc [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ara-0.13.0-1.fc25.noarch.rpm ara-python3-0.13.0-1.fc25.noarch.rpm python2-ara-0.13.0-1.fc25.noarch.rpm python2-ara-tests-0.13.0-1.fc25.noarch.rpm python3-ara-0.13.0-1.fc25.noarch.rpm python3-ara-tests-0.13.0-1.fc25.noarch.rpm ara-common-0.13.0-1.fc25.noarch.rpm ara-doc-0.13.0-1.fc25.noarch.rpm ara-0.13.0-1.fc25.src.rpm ara.noarch: W: spelling-error Summary(en_US) Ansible -> Expansible, Sensible ara.noarch: W: name-repeated-in-summary C ARA ara.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible ara.noarch: W: no-manual-page-for-binary ara ara.noarch: W: no-manual-page-for-binary ara-2 ara.noarch: W: no-manual-page-for-binary ara-2.7 ara.noarch: W: no-manual-page-for-binary ara-manage ara.noarch: W: no-manual-page-for-binary ara-manage-2 ara.noarch: W: no-manual-page-for-binary ara-manage-2.7 ara.noarch: W: no-manual-page-for-binary ara-wsgi ara.noarch: W: no-manual-page-for-binary ara-wsgi-2 ara.noarch: W: no-manual-page-for-binary ara-wsgi-2.7 ara-python3.noarch: W: spelling-error Summary(en_US) Ansible -> Expansible, Sensible ara-python3.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible ara-python3.noarch: W: no-manual-page-for-binary ara-3 ara-python3.noarch: W: no-manual-page-for-binary ara-3.6 ara-python3.noarch: W: no-manual-page-for-binary ara-manage-3 ara-python3.noarch: W: no-manual-page-for-binary ara-manage-3.6 ara-python3.noarch: W: no-manual-page-for-binary ara-wsgi-3 ara-python3.noarch: W: no-manual-page-for-binary ara-wsgi-3.6 python2-ara.noarch: W: spelling-error Summary(en_US) Ansible -> Expansible, Sensible python2-ara.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible python2-ara.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/ara/db/env.py python2-ara.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/ara/db/script.py.mako python2-ara.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ara/manage.py /usr/bin/env python python2-ara.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ara/manage.py 644 /usr/bin/env python python2-ara-tests.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible python2-ara-tests.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ara/tests/integration/helpers/junit_check.py /usr/bin/env python python2-ara-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ara/tests/integration/helpers/junit_check.py 644 /usr/bin/env python python3-ara.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible python3-ara.noarch: E: script-without-shebang /usr/lib/python3.6/site-packages/ara/db/env.py python3-ara.noarch: E: script-without-shebang /usr/lib/python3.6/site-packages/ara/db/script.py.mako python3-ara.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/ara/manage.py /usr/bin/env python python3-ara.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/ara/manage.py 644 /usr/bin/env python python3-ara-tests.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible python3-ara-tests.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/ara/tests/integration/helpers/junit_check.py /usr/bin/env python python3-ara-tests.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/ara/tests/integration/helpers/junit_check.py 644 /usr/bin/env python ara-common.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible ara-common.noarch: W: non-standard-gid /etc/ara/ara.cfg ara ara-common.noarch: E: non-readable /etc/ara/ara.cfg 640 ara-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/ara ara-common.noarch: W: non-standard-uid /var/lib/ara ara ara-common.noarch: W: non-standard-gid /var/lib/ara ara ara-common.noarch: E: non-standard-dir-perm /var/lib/ara 750 ara-common.noarch: W: non-standard-uid /var/log/ara ara ara-common.noarch: W: non-standard-gid /var/log/ara ara ara-common.noarch: E: non-standard-dir-perm /var/log/ara 750 ara-doc.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible ara-doc.noarch: W: hidden-file-or-dir /usr/share/doc/ara-doc/html/.buildinfo ara-doc.noarch: W: hidden-file-or-dir /usr/share/doc/ara-doc/html/.doctrees ara-doc.noarch: W: hidden-file-or-dir /usr/share/doc/ara-doc/html/.doctrees ara.src: W: spelling-error Summary(en_US) Ansible -> Expansible, Sensible ara.src: W: name-repeated-in-summary C ARA ara.src: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible ara.src:52: W: macro-in-comment %check ara.src:125: W: macro-in-comment %check ara.src: E: specfile-error Python runtime initialized with LC_CTYPE=C (a locale with default ASCII encoding), which may cause Unicode compatibility problems. Using C.UTF-8, C.utf8, or UTF-8 (if available) as alternative Unicode-compatible locales is recommended. ara.src: E: specfile-error Python runtime initialized with LC_CTYPE=C (a locale with default ASCII encoding), which may cause Unicode compatibility problems. Using C.UTF-8, C.utf8, or UTF-8 (if available) as alternative Unicode-compatible locales is recommended. ara.src: E: specfile-error Python runtime initialized with LC_CTYPE=C (a locale with default ASCII encoding), which may cause Unicode compatibility problems. Using C.UTF-8, C.utf8, or UTF-8 (if available) as alternative Unicode-compatible locales is recommended. ara.src: E: specfile-error Python runtime initialized with LC_CTYPE=C (a locale with default ASCII encoding), which may cause Unicode compatibility problems. Using C.UTF-8, C.utf8, or UTF-8 (if available) as alternative Unicode-compatible locales is recommended. ara.src: E: specfile-error Python runtime initialized with LC_CTYPE=C (a locale with default ASCII encoding), which may cause Unicode compatibility problems. Using C.UTF-8, C.utf8, or UTF-8 (if available) as alternative Unicode-compatible locales is recommended. ara.src: E: specfile-error Python runtime initialized with LC_CTYPE=C (a locale with default ASCII encoding), which may cause Unicode compatibility problems. Using C.UTF-8, C.utf8, or UTF-8 (if available) as alternative Unicode-compatible locales is recommended. 9 packages and 0 specfiles checked; 22 errors, 40 warnings. Rpmlint (installed packages) ---------------------------- python3-ara-tests.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible python3-ara-tests.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/ara/tests/integration/helpers/junit_check.py /usr/bin/env python python3-ara-tests.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/ara/tests/integration/helpers/junit_check.py 644 /usr/bin/env python python2-ara.noarch: W: spelling-error Summary(en_US) Ansible -> Expansible, Sensible python2-ara.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible python2-ara.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/ara/db/env.py python2-ara.noarch: E: script-without-shebang /usr/lib/python2.7/site-packages/ara/db/script.py.mako python2-ara.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ara/manage.py /usr/bin/env python python2-ara.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ara/manage.py 644 /usr/bin/env python python3-ara.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible python3-ara.noarch: E: script-without-shebang /usr/lib/python3.6/site-packages/ara/db/env.py python3-ara.noarch: E: script-without-shebang /usr/lib/python3.6/site-packages/ara/db/script.py.mako python3-ara.noarch: E: wrong-script-interpreter /usr/lib/python3.6/site-packages/ara/manage.py /usr/bin/env python python3-ara.noarch: E: non-executable-script /usr/lib/python3.6/site-packages/ara/manage.py 644 /usr/bin/env python python2-ara-tests.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible python2-ara-tests.noarch: E: wrong-script-interpreter /usr/lib/python2.7/site-packages/ara/tests/integration/helpers/junit_check.py /usr/bin/env python python2-ara-tests.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/ara/tests/integration/helpers/junit_check.py 644 /usr/bin/env python ara.noarch: W: spelling-error Summary(en_US) Ansible -> Expansible, Sensible ara.noarch: W: name-repeated-in-summary C ARA ara.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible ara.noarch: W: no-manual-page-for-binary ara ara.noarch: W: no-manual-page-for-binary ara-2 ara.noarch: W: no-manual-page-for-binary ara-2.7 ara.noarch: W: no-manual-page-for-binary ara-manage ara.noarch: W: no-manual-page-for-binary ara-manage-2 ara.noarch: W: no-manual-page-for-binary ara-manage-2.7 ara.noarch: W: no-manual-page-for-binary ara-wsgi ara.noarch: W: no-manual-page-for-binary ara-wsgi-2 ara.noarch: W: no-manual-page-for-binary ara-wsgi-2.7 ara-common.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible ara-common.noarch: W: non-standard-gid /etc/ara/ara.cfg ara ara-common.noarch: E: non-readable /etc/ara/ara.cfg 640 ara-common.noarch: E: incoherent-logrotate-file /etc/logrotate.d/ara ara-common.noarch: W: non-standard-uid /var/lib/ara ara ara-common.noarch: W: non-standard-gid /var/lib/ara ara ara-common.noarch: E: non-standard-dir-perm /var/lib/ara 750 ara-common.noarch: W: non-standard-uid /var/log/ara ara ara-common.noarch: W: non-standard-gid /var/log/ara ara ara-common.noarch: E: non-standard-dir-perm /var/log/ara 750 ara-python3.noarch: W: spelling-error Summary(en_US) Ansible -> Expansible, Sensible ara-python3.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible ara-python3.noarch: W: no-manual-page-for-binary ara-3 ara-python3.noarch: W: no-manual-page-for-binary ara-3.6 ara-python3.noarch: W: no-manual-page-for-binary ara-manage-3 ara-python3.noarch: W: no-manual-page-for-binary ara-manage-3.6 ara-python3.noarch: W: no-manual-page-for-binary ara-wsgi-3 ara-python3.noarch: W: no-manual-page-for-binary ara-wsgi-3.6 ara-doc.noarch: W: spelling-error %description -l en_US Ansible -> Expansible, Sensible ara-doc.noarch: W: hidden-file-or-dir /usr/share/doc/ara-doc/html/.buildinfo ara-doc.noarch: W: hidden-file-or-dir /usr/share/doc/ara-doc/html/.doctrees ara-doc.noarch: W: hidden-file-or-dir /usr/share/doc/ara-doc/html/.doctrees 8 packages and 0 specfiles checked; 16 errors, 35 warnings. Requires -------- python3-ara-tests (rpmlib, GLIBC filtered): python(abi) python3-ara python3-lxml python3-pytest python2-ara (rpmlib, GLIBC filtered): ansible python(abi) python-cliff python-flask-script python-frozen-flask python2-XStatic python2-XStatic-Bootstrap-SCSS python2-XStatic-DataTables python2-XStatic-Patternfly python2-XStatic-Patternfly-Bootstrap-Treeview python2-XStatic-jQuery python2-debtcollector python2-decorator python2-flask python2-flask-migrate python2-jinja2 python2-junit_xml python2-pyfakefs python2-pygments python2-sqlalchemy python3-ara (rpmlib, GLIBC filtered): ansible-python3 python(abi) python3-XStatic python3-XStatic-Bootstrap-SCSS python3-XStatic-DataTables python3-XStatic-Patternfly python3-XStatic-Patternfly-Bootstrap-Treeview python3-XStatic-jQuery python3-cliff python3-debtcollector python3-decorator python3-flask python3-flask-migrate python3-flask-script python3-frozen-flask python3-jinja2 python3-junit_xml python3-pyfakefs python3-pygments python3-sqlalchemy python2-ara-tests (rpmlib, GLIBC filtered): python(abi) python-pytest python2-ara python2-lxml ara (rpmlib, GLIBC filtered): /bin/sh /usr/bin/python2 ara-common python2-ara systemd ara-common (rpmlib, GLIBC filtered): /bin/sh config(ara-common) shadow-utils ara-python3 (rpmlib, GLIBC filtered): /usr/bin/python3 ara-common python3-ara ara-doc (rpmlib, GLIBC filtered): Provides -------- python3-ara-tests: python3-ara-tests python2-ara: python-ara python2-ara python2.7dist(ara) python2dist(ara) python3-ara: python3-ara python3.6dist(ara) python3dist(ara) python2-ara-tests: python2-ara-tests ara: ara ara-common: ara-common config(ara-common) ara-python3: ara-python3 ara-doc: ara-doc Source checksums ---------------- https://pypi.io/packages/source/a/ara/ara-0.13.0.tar.gz : CHECKSUM(SHA256) this package : 13aa1b20065fa2cae819b045e57b7c55983ca60e830ac2e72b056c322a743900 CHECKSUM(SHA256) upstream package : 13aa1b20065fa2cae819b045e57b7c55983ca60e830ac2e72b056c322a743900 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1426193 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
