Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-password-generator - Graphical secure password generator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245649 ------- Additional Comments From debarshi.ray@xxxxxxxxx 2007-07-30 22:17 EST ------- > * BuildRequires > - I just watched Makefile and I don't think this package > must have gnome-python2 pygtk2-devel as BuildRequires. Fixed. I wonder why the Dag Apt and FC6 package had them. > * Requires > - It may well that this package has "Requires: redhat-artwork". Fixed. > * icon > - By the way, why do you have to install icon under > %{_datadir}/icons/hicolor/48x48/apps, even though it is > also installed under %{_datadir}/pixmaps/ ? While creating the initial build, I was told on #fedora-devel that only icons placed under %{_datadir}/icons/hicolor are themeable, while stuff under %{_datadir}/pixmaps are non-themeable. I was advised to put the icons under %{_datadir}/icons/hicolor/48x48/apps. However the icon size is 96x96, and so I have now put it under %{_datadir}/icons/hicolor/96x96/apps. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review