https://bugzilla.redhat.com/show_bug.cgi?id=1459914 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- You're missing some rather important BuildRequires, for /usr/bin/sip and poppler-qt5. You can fix that by adding these lines: BuildRequires: pkgconfig(poppler-qt5) BuildRequires: sip-devel A koji scratch build would have caught that immediately. Next time, consider test building your SRPM there first (e.g. koji build --scratch f26-build nameof.src.rpm). With those two lines added, I finished the review. Please be sure that you add those lines before you commit. :) == REVIEW == Good: - rpmlint checks return nothing - package meets naming guidelines - package meets general and python packaging guidelines - license (LGPLv2+) OK, matches source (though, you really should ask upstream to include a copy of the LGPLv2 COPYING text, it is missing from their source tree) - spec file legible, in am. english - source matches upstream - package compiles on f26 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
