https://bugzilla.redhat.com/show_bug.cgi?id=812758 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review+ --- Comment #29 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- Five year old review ticket still alive? Yeah, I'll take this one for the karma. :) John, please tell me what your Fedora Account System username is so I can sponsor you. == Review == Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (b769379a3bd03f3c742e80aacc4160bd60935c84882f0b1b841096acd88df114) - package compiles on F26 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - .desktop file okay APPROVED. You are now here in this process: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers?rd=PackageMaintainers/Join#Get_Sponsored I will sponsor you once I know your FAS username. Questions, comments, help needed? Let me know. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
