[Bug 1450477] Review Request: ratbagd - the libratbag daemon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1450477

Peter Hutterer <peter.hutterer@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(btissoir@redhat.c
                   |                            |om)



--- Comment #4 from Peter Hutterer <peter.hutterer@xxxxxxxxxx> ---
merci, looks like there's still a few things left to do tough

* libratbag dependency upstream is >= 0.6, spec file is still at 0.4

* rpmlint complains: "ratbagd.src: W: spelling-error %description -l en_US
nonprivileged -> non privileged, non-privileged, underprivileged
ratbagd.src:23: W: unversioned-explicit-provides python3-ratbagd"
→ please hyphenate non-privileged

* ratbagd-python.noarch: E: wrong-script-interpreter /usr/bin/ratbagctl
/usr/bin/env python
→ that's an upstream bug, should be '/usr/bin/env python3', see
https://github.com/libratbag/ratbagd/pull/26

* the man page for ratbagctl should be in the -python subpackage

* From  https://fedoraproject.org/wiki/Packaging:Python:
"Must: If you build for a single python runtime you must add %python_provide
python-$module so that the current default python is provided from the
unversioned python package."
afaict all other conditions are met here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux