Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: PyQt4: Python bindings for Qt4 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=190189 ------- Additional Comments From bos@xxxxxxxxxxxxxx 2007-07-30 17:06 EST ------- OK, here's my review. The following files most likely belong in the -devel package, not the main PyQt4 package: /usr/bin/pylupdate4 /usr/bin/pyrcc4 /usr/bin/pyuic4 Must fix rpmlint errors: E: PyQt4 non-executable-script /usr/lib/python2.5/site-packages/PyQt4/uic/pyuic.py 0644 E: PyQt4 script-without-shebang /usr/bin/pyuic4 E: PyQt4 binary-or-shlib-defines-rpath /usr/lib/python2.5/site-packages/PyQt4/QtDesigner.so ['/home/bos/rpms/BUILD/PyQt-x11-gpl-4.2/qpy/QtDesigner'] Also, it would be good to fix the 228 (!) rpmlint warnings on the -devel package, which I attached several months ago. Beyond the above, all other MUSTs look good. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review