https://bugzilla.redhat.com/show_bug.cgi?id=1427085 --- Comment #10 from Damian Wrobel <dwrobel@xxxxxxxxxxxxxxxxxx> --- (In reply to Raphael Groner from comment #9) > Thanks for your fixes, but there is still a need of some important comments … > > >> MUST fix: > >> - update-desktop-database is invoked in %post and %postun if package > > removed > It's not fixed, please try again. > http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database It's removed and I don't see it in the spec file. The following command proves it: $ curl -s https://dwrobel.fedorapeople.org/projects/rpmbuild/SPECS/plantumlqeditor.spec | grep update-desktop-database | wc -l 0 > > >> - Remove duplication of folders ownership, see note below. > > removed, except %{_datadir}/icons/hicolor/scalable/apps for which I applied: > > https://fedoraproject.org/wiki/Packaging:Guidelines#The_package_you_depend_on_to_provide_a_directory_may_choose_to_own_a_different_directory_in_a_later_version_and_your_package_will_run_unmodified_with_that_later_version > Nearly right. Though, you have to remove ownership of > %{_datadir}/icons/hicolor and all subdirectories because it's obviousl owned > by hicolor-icon-theme and 'Requires: hicolor-icon-theme' is sufficient. I'll remove it. Although, it not clear to me where it's guaranteed that hicolor-icon-theme will not change directory structure in the future. > > [?]: %check is present and all tests pass. > You should run the tests provided by upstream in %check. > https://github.com/borco/plantumlqeditor/tree/master/tests As I mentioned, I didn't touch it because upstream does not even provide a method to compile it with a qmake. Could you please confirm there is no issue with update-desktop-database before I will modify the spec. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
