[Bug 1451411] Review Request: python-flask-httpauth - Basic and Digest HTTP authentication for Flask routes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1451411

Chandan Kumar <chkumar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chkumar@xxxxxxxxxx,
                   |                            |jpena@xxxxxxxxxx
              Flags|                            |needinfo?(jpena@xxxxxxxxxx)



--- Comment #1 from Chandan Kumar <chkumar@xxxxxxxxxx> ---
Thanks Jpena for putting the Package Review.

Below is some of my comments:
* The current pypi tarball does not contains docs and tests folder, please use
  github tarball.
Note: I have added a patch upstream to include docs and tests in pypi tarball:
https://github.com/miguelgrinberg/Flask-HTTPAuth/pull/55

* Add -docs and -tests subpackage to the project as well as include %check
section 
  to run unit tests.

Rest looks ok to me.

Thanks,

Chandan Kumar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux