https://bugzilla.redhat.com/show_bug.cgi?id=1428202 --- Comment #5 from Raphael Groner <projects.rg@xxxxxxxx> --- Daniel, thanks for your comments. Spec URL: https://raphgro.fedorapeople.org/review/util/sirikali.spec SRPM URL: https://raphgro.fedorapeople.org/review/util/sirikali-1.2.5-2.fc26.src.rpm Task info: https://koji.fedoraproject.org/koji/taskinfo?taskID=19859311 (In reply to Damian Wrobel from comment #2) > Please find some initial comments: > > %doc COPYING > COPYING should go to %license, please also remove the redundant space > character in front of %doc fixed > %doc README* > It's minor, but it causes that both README and README.md are packaged, > although both are identical: > $ sha256sum README README.md > 6b6f723b4db0fe3468e32a6cb488c42f2cc3c499538367bb89bebd3b432fe6c6 README > 6b6f723b4db0fe3468e32a6cb488c42f2cc3c499538367bb89bebd3b432fe6c6 README.md > Maybe upstream can simply remove one of it? fixed, no README found in current trunk > %dir %{_datadir}/%{name}/translations > %dir %{_datadir}/%{name} > Please consider reverting the order of them, will look more natural. fixed > -rwxr-xr-x 1 root root 332 Mar 8 16:24 > /usr/share/applications/sirikali.desktop > Destkop file seems to have superfluous executable attribute. fixed > Based on the project's homepage[1]: … > gocryptfs binary application is required to be installed for SiriKali to > gain support for gocryptfs volumes. no package found for gocryptfs, it needs golang [1] etc. to build properly, maybe come back to gocryptfs later https://nuetzlich.net/gocryptfs/compile/ > encfs binary application is required to be installed for SiriKali to gain > support for encfs volumes. fixed with weak dependency to fuse-encfs > securefs binary application is required to be installed for SiriKali to gain > support for securefs volumes. no idea about this, please ignore … > $ dnf provides '*cryfs' > Last metadata expiration check: 2:21:08 ago on Wed Mar 8 15:59:56 2017. > Error: No Matches found > > [1] https://mhogomchungu.github.io/sirikali/ there's an upstream issue [2] about docker and Fedora. PCLinuxOS has some effort [3] to ship a package of cryfs, maybe worth to look into their srpm, though: "This package is obsolete. Try find newer cryfs-gui [4]" owned by same upstream as of sirikali [2] https://github.com/cryfs/cryfs/issues/89 [3] http://rpm.pbone.net/index.php3/stat/4/idpl/34219112/dir/pclinuxos/com/cryfs-gui-1.3.1-2pclos2016.x86_64.rpm.html [4] https://github.com/mhogomchungu/cryfs-gui/blob/master/rpm/cryfs-gui.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
