[Bug 1458247] Review Request: translate-shell - a command-line online translator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1458247



--- Comment #4 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> ---
Manual checks:

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.

Pass.

[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated". 37 files have unknown license. Detailed
     output of licensecheck in /home/vitaly/1458247-translate-
     shell/licensecheck.txt

Pass. But you should ask upstream to add Public Domain preamble to source
files.

[ ]: Package contains no bundled libraries without FPC exception.

Pass.

[ ]: Changelog in prescribed format.

Pass.

[ ]: Sources contain only permissible code or content.

Pass.

[ ]: Package contains desktop file if it is a GUI application.

Pass. N/a.

[ ]: Development files must be in a -devel package

Pass.

[ ]: Package uses nothing in %doc for runtime.

Pass.

[ ]: Package consistently uses macros (instead of hard-coded directory
     names).

Pass.

[ ]: Package is named according to the Package Naming Guidelines.

Pass.

[ ]: Package does not generate any conflict.

Pass.

[ ]: Package obeys FHS, except libexecdir and /usr/target.

Pass.

[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.

Pass.

[ ]: Requires correct, justified where necessary.

Pass.

[ ]: Spec file is legible and written in American English.

Pass.

[ ]: Package contains systemd file(s) if in need.

Pass. N/a.

[ ]: Package is not known to require an ExcludeArch tag.

Pass. N/a.

[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 3 files.

Pass.

[ ]: Package complies to the Packaging Guidelines

Pass.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux