Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: and - Auto nice daemon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=249590 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-07-30 14:15 EST ------- I think something is wrong with your scriptlet dependencies; post does not call /sbin/service. I think perhaps you meant Requires(postun): /sbin/service Since this is just a two-character typo and is the only thing I see wrong with this package, I'll go ahead and approve it and you can fix it when you check in. Review: * source files match upstream: d34a09d7a396bcf19beb0002195c5862b62292b04fd1fb5a83ae382955f28118 and-1.2.2.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper (none) * compiler flags are appropriate. * %clean is present. * package builds in mock (development, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: config(and) = 1.2.2-2.fc8 and = 1.2.2-2.fc8 = /bin/sh /sbin/chkconfig /sbin/service config(and) = 1.2.2-2.fc8 * %check is not present; no test suite upstream. I installed the package and made sure the service would start and stop properly. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. X scriptlets look OK but dependencies are slightly off. * init script looks good and seems to conform to LSB requirements. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED, just fix the %postun scriptlet dependency. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review