https://bugzilla.redhat.com/show_bug.cgi?id=1457929 Pavel Raiskup <praiskup@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acaringi@xxxxxxxxxx, | |hhorak@xxxxxxxxxx, | |mschorm@xxxxxxxxxx Flags| |needinfo?(acaringi@redhat.c | |om) --- Comment #3 from Pavel Raiskup <praiskup@xxxxxxxxxx> --- > 1. There is the question regarding the user/group. I would prefer to discuss this with mysql/mariadb maintainers, so I'm CCing Michal/Honza. My personal preference is somewhere between 1.3 or 1.4, though that's my POV; reasoning is that it is pretty ugly to create the same users and UIDs in several spec files. > 2. I did a koji scratch build and it fails on arm architecture due to some > use of x86 assembly code. It seems that the upstream is already aware: We can probably ExcludeArch for the time being. > 3. rpmlint complains about 2 things: > > 3.1: The lacking of man page for proxysql: > > W: no-manual-page-for-binary proxysql It is fair to provide downstream manual page in such cases, and propose it upstream, too. Also, have a look at help2man. This is warning-only but installing a binary into %_bindir deserves manpage in Fedora. > 3.2: Crypto policies: > > W: crypto-policy-non-compliance-openssl /usr/bin/proxysql SSL_CTX_set_cipher_list Have a look at [2]. The spec file looks nice, thanks! Some things that are worth looking at: * license tag says 'GPL+', but the license file seems to be 'GPLv3' * there are some bundled libraries, I would suggest to investigate (a) whether we can de-bundle, or (b) add artificial Provides according to [1] or if that code is not used -- we could (c) 'rm -rf' the source directory to make sure that the code is not used in spec file. Note that if the bundling is needed, there are several other license files in the provided tarball. * /usr/share/doc/proxysql directory is not owned by the package, /usr/share/proxysql/tools neither * there's no %configure, which means %optflags are not used automatically - this probably needs to be added * consider working together with upstream on having better 'make install' code ... so we can use this, for the time being - please at least raise issue upstream and put the link near manual `install` commands in %install so everybody understands that this is temporary issue.. * %bulidroot%_bindir is enough (no need for the additional '/' in between) [1] https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries [2] https://fedoraproject.org/wiki/Packaging:CryptoPolicies -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
