[Bug 1433749] Review Request: vrms-rpm - report of installed nonfree software

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1433749



--- Comment #9 from Neal Gompa <ngompa13@xxxxxxxxx> ---
> URL:           https://github.com/%{githubowner}/%{name}/
> Source0:       %{url}archive/%{gittag0}.tar.gz#/%{name}-%{gittag0}.tar.gz

Please adjust the URL structure to be properly segmented. For example:

URL:           https://github.com/%{githubowner}/%{name}
Source0:       %{url}/archive/%{gittag0}/%{name}-%{gittag0}.tar.gz

> make build PREFIX=/usr %{?_smp_mflags}

Please use %{_prefix} for PREFIX= value. Also, as an alternative, you can
simplify this with "%make_build PREFIX=%{_prefix}"

> make install PREFIX=%{buildroot}/usr %{?_smp_mflags}

Use %{buildroot}%{_prefix} here. Also, consider supporting DESTDIR so that the
standard %make_install macro works.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux