https://bugzilla.redhat.com/show_bug.cgi?id=1455886 --- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> --- (In reply to mgansser@xxxxxxxx from comment #2) > (In reply to Vít Ondruch from comment #1) > > Just two quick notes moment: > > > > 1) I am not sure whether the "Recommends: flash-plugin" is legit, i.e. if > > you can reference 3rd party repositories. You should probably consult this > > with some ML (legal?, packaging?, devel?). > > I have started a discussion on the packaging forum [3]. As far as I understand the ML discussion, the references to 3rd party repositories are not allowed in Fedora. Please drop the "Recommends: flash-plugin" > > > > 2) Since this is add-on package, it should contain add-on metadata [1]. This > > way, Gnome Software will be able to list this add-on side by side with > > Nuvola player, which is pretty convenient. > > > > > > [1]: > > https://fedoraproject.org/wiki/Packaging:AppData#.metainfo.xml_file_creation > > I added a metainfo.xml file to the spec file. Thx. Have you tried to submit the file upstream? Unfortunately, the build does not work at all: https://koji.fedoraproject.org/koji/taskinfo?taskID=19799178 This seems to be related to the changes announced by upstream [1] and probably triggered by the nuvolasdk. This makes me think about providing either some helper macros, which would hide this changes, providing something like nuvolaplayer-filesystem or possibly requirement to be more strict about versioning of the interdependencies. [1] https://medium.com/nuvola-news/nuvola-4-4-supports-appindicators-in-unity-elementaryos-and-gnome-changes-versioning-scheme-a323b80e5cda#8450 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
