https://bugzilla.redhat.com/show_bug.cgi?id=1452985 Paul Howarth <paul@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul@xxxxxxxxxxxx --- Comment #4 from Paul Howarth <paul@xxxxxxxxxxxx> --- A few quick comments: I think running rpm database queries in the package build is a bad idea. This may fail when building in a chroot environment populated using a version of rpm using a different version of libdb to the target for instance. Can't you get the rakudo version from rakudo itself? Do you know of any other perl6 packages in Fedora already? At this stage there don't appear to be any Perl6 packaging guidelines so it would be good to at least be consistent with what's there already, if anything. I don't think you need to gzip the manpage; rpm should do that itself, and may choose to use a different compression format in the future. You should BR: perl-podlators for pod2man. Consider also optionally adding BR: for coreutils and sed, which the spec calls for in %install. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
