https://bugzilla.redhat.com/show_bug.cgi?id=1433658 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tcallawa@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |tcallawa@xxxxxxxxxx Flags| |fedora-review+ --- Comment #4 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> --- Mustfix (before commit): * Do not "mv" %{SOURCE} files. cp -a. :) * There is a typo in the devel %description, "teimplate". Good: - rpmlint checks return: mustache-d-devel.x86_64: W: spelling-error %description -l en_US teimplate -> template, implicate - package meets naming guidelines - package meets packaging guidelines - license (Boost) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (b8cf5fe193b11dece663ad2d7f8acbcc02ef48334f0fdc922a2dde3f8ac64b57) - package compiles on F26 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - .a files come with proper static provides Fix your MUSTFIX items before commit. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
