https://bugzilla.redhat.com/show_bug.cgi?id=1452649 --- Comment #13 from Luke Hinds <lhinds@xxxxxxxxxx> --- Apologies, I did not git add the newer spec and srpm: >> [!]: Package requires other packages for directories it uses. >> Note: No known owner of /usr/share/exabgp >> [!]: Package must own all directories that it creates. >> Note: Directories without known owners: /usr/share/exabgp >> >> Probably need to add %dir for this directory. >> >> By the way, in the spec you can use %{_datadir} instead of >> %{_prefix}/share. > This is not fixed. This should be fixed now. I used the following lines: %dir %{_datadir}/exabgp %dir %{_datadir}/exabgp/processes >> [!]: Each %files section contains %defattr if rpm < 4.4 >> Note: %defattr present but not needed >> >> %defattr isn't required even for RHEL 7, so this should be deleted >> unless you're really intending to use this spec file for ancient >> versions of RPM. > Not fixed. Removed %defattr >> [!]: Requires correct, justified where necessary. >> >> It seems as if the exabgp subpackage should have >> ‘Requires: %{name} = %{version}-%{release}’. >> >> Currently the exabgp package requires ‘config(exabgp)’ which >> python-exabgp provides, but that won't be sufficient to pull in the >> correct version. > Not fixed. Added: Requires: %{name} = %{version}-%{release} >> [ ]: Package complies to the Packaging Guidelines >> >> Possibly, but I still think the not-really-config /etc/exabgp/examples >> files should be moved to /usr/lib/exabgp. > Not changed. Now using lib (or rather lib64 which is referenced by _libdir) mv ${RPM_BUILD_ROOT}/usr/share/exabgp/etc/* ${RPM_BUILD_ROOT}/%{_libdir}/exabgp/ >> [ ]: Final provides and requires are sane (see attachments). >> >> I suspect exabgp should require python-exabgp. The other dependencies >> look fine. >> >> [!]: Fully versioned dependency in subpackages if applicable. >> Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in exabgp >> >> See above. I get a pass on this now. [x]: Fully versioned dependency in subpackages if applicable. I also have no failures [!] and the only `Issue` is: - Permissions on files are set properly -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
