https://bugzilla.redhat.com/show_bug.cgi?id=1456203 --- Comment #6 from Rémi Verschelde <rverschelde@xxxxxxxxx> --- Thanks for the review. All issues should be addressed in the updated version (same URLs): Spec URL: http://remi.verschelde.fr/files/packages/fedora/jumpnbump.spec SRPM URL: http://remi.verschelde.fr/files/packages/fedora/jumpnbump-1.60-1.mga6.src.rpm >- gtk-update-icon-cache is invoked in %postun and %posttrans if package > contains icons. > Note: icons in jumpnbump > See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache Done. The documentation explicitly mentions that the scriptlet is needed for "subdirectories" of %{_datadir}/icons/, while here we're in the top folder directory. But supposing the review tool knows its business, I assume that it's a broad "subdirectories" as in "that directory and all its subdirectories". It does make sense. > jumpnbump.x86_64: E: invalid-appdata-file /usr/share/appdata/jumpnbump.appdata.xml There was actually a mistake in the appdata file, it still referenced the old GitHub repository instead of the new GitLab one. Fixed with an upstream patch. > jumpnbump-menu.noarch: E: wrong-script-interpreter /usr/bin/jumpnbump-menu /usr/bin/env python Fixed with an upstream patch too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
