[Bug 1456203] Review Request: jumpnbump - Cute multiplayer platform game with bunnies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1456203



--- Comment #3 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Some issues of note:

>- gtk-update-icon-cache is invoked in %postun and %posttrans if package
>  contains icons.
>  Note: icons in jumpnbump
>  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

Apparently, you do need them even for regular icons. I suppose it makes sense,
given what it's for. Since this hasn't been implemented as a file trigger, it
needs to be in the spec.

> [!]: Uses parallel make %{?_smp_mflags} macro.

This is documented and known.

> jumpnbump.x86_64: W: only-non-binary-in-usr-lib
> jumpnbump.x86_64: W: hidden-file-or-dir /usr/lib/.build-id
> jumpnbump.x86_64: W: hidden-file-or-dir /usr/lib/.build-id

Related to new debuginfo changes, ignore.

> jumpnbump.x86_64: E: invalid-appdata-file /usr/share/appdata/jumpnbump.appdata.xml

This is odd. In your %check section, it's declared valid... I'll ignore this
for now.

> jumpnbump-menu.noarch: E: wrong-script-interpreter /usr/bin/jumpnbump-menu /usr/bin/env python

I suggest changing the interpreter via sed like so:

sed -e "s:#!/usr/bin/env python/%{__python2}/:"
%{buildroot}%{_bindir}/jumpnbump-menu

The %__python2 macro requires python2-devel pulled in as a BR, which you need
to do anyway since there's Python stuff in here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux