https://bugzilla.redhat.com/show_bug.cgi?id=1451298 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zbyszek@xxxxxxxxx --- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- Some trivialities up front: - you should link to the plain spec file and src.rpm, so that tools like fedora-review can download the package. So link to http://copr-dist-git.fedorainfracloud.org/cgit/thanosapostolou/vertex-theme/vertex-theme.git/plain/vertex-theme.spec instead. - The %description should be wrapped to <= 80 columns. About 72 is good. - it looks like you have mixed tab and spaced indentation. Nowadays spaces are standard, so I'd recommend just using that. But either way, you should just stick to one style of indentation, so everything lines up no matter how many spaces the tab is interpreted as (if you use tabs). - You should drop Group tag [https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]. - You should remove the package name from the Summary — a listing will usually show the package name anyway, and space is at premium. Looks good apart from those (relatively minor) issues. -- To move things along, you will want to do some reviews of other packages. It's the best way to learn how other people do packaging, and the different tricks used for different languages and package types. You should start with setting up a mock environment and running fedora-review on some packages. (I assume you haven't done that on this package, c.f. the first para of my comment ;)). ATM I cannot find good instructions how to install and configure mock, but essentially 'sudo dnf install mock && sudo usermod -a -G mock myusername'. You can then test building your srpm in mock. Once that's working, you can run fedora-review on this bug ('fedora-review -b 1451298'), and others. I'd suggest reviewing #1421506. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
