https://bugzilla.redhat.com/show_bug.cgi?id=1440384 --- Comment #7 from Rex Dieter <rdieter@xxxxxxxxx> --- Sorry for the extended delay... naming: 1. SHOULD consider naming in lower case, see also https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines dependencies: 2. MUST: Document the need for explicit library depenedencies: Requires: libxcb Requires: xcb-util Requires: qt5-qtx11extras (I'm guessing these may not really be needed) See also: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Explicit_Requires 3. SHOULD drop deprecated stuff: %clean (the %clean section can be removed altogether) (in %files) %defattr... (in %install section) %{__rm} -rf %{buildroot} 4. SHOULD not use %{make_install}, which is intended for autotools-based projects mostly, I suggest changing %{make_install} DESTDIR=%{buildroot} -C build to make install/fast DESTDIR=%{buildroot} -C build 5. MUST be more explicit in %%files, use %%find_lang, and use less globs, something like: in %install section (after 'make install...'): %find_lang %{name} --all-name and in %files: %files -f %{name}.lang %{_bindir}/latte-dock %{_kf5_datadir}/appdata/org.kde.latte.containment.appdata.xml %{_kf5_datadir}/appdata/org.kde.latte.plasmoid.appdata.xml %{_kf5_datadir}/appdata/org.kde.latte.shell.appdata.xml %{_kf5_datadir}/applications/latte-dock.desktop %{_kf5_datadir}/dbus-1/interfaces/org.kde.LatteDock.xml %{_kf5_datadir}/icons/breeze/*/*/* %{_kf5_datadir}/icons/hicolor/*/*/* %{_kf5_datadir}/knotifications5/lattedock.notifyrc %{_kf5_datadir}/kservices5/plasma-applet-org.kde.latte.containment.desktop %{_kf5_datadir}/kservices5/plasma-applet-org.kde.latte.plasmoid.desktop %{_kf5_datadir}/kservices5/plasma-shell-org.kde.latte.shell.desktop %{_kf5_datadir}/plasma/plasmoids/org.kde.latte.containment/ %{_kf5_datadir}/plasma/plasmoids/org.kde.latte.plasmoid/ %{_kf5_datadir}/plasma/shells/org.kde.latte.shell/ %{_kf5_qmldir}/org/kde/latte/ 6. %build section uses pushd, but there's no popd. It's mostly harmless as is currently, but could cause problems later. SHOULD add matching 'pop'd near end of %build section licensing: ok sources: ok 8b7f07a3ba2a9296d6d7f83d7e83e7d1 v0.6.2.tar.gz Please address items 1-6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
