Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: nabi - hangul and hanja X input method Alias: nabi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=247227 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-07-30 10:06 EST ------- (In reply to comment #11) > Upgraded to 0.18 release. > Spec URL: http://oriya.sourceforge.net/nabi.spec (In reply to comment #12) > Created an attachment (id=160216) --> (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=160216&action=view) [edit] > nabi.spec-4.patch > > some more fixes - please check I didn't break anything. :) (I only glanced at both spec files) More cleanup: * Please use full path for the commands which are not under normal users' paths. * The following is smarter ----------------------------------------------------------- desktop-file-install --dir=${RPM_BUILD_ROOT}%{_datadir}/applications/ \ %SOURCE1 ----------------------------------------------------------- ! Note: desktop-file-install automatically fix the following, however Categories must be seperated by semicolon: i.e. ----------------------------------------------------------- Categories=System; ----------------------------------------------------------- * What is the use of the line: ----------------------------------------------------------- %attr(755,root,root) ----------------------------------------------------------- ? Question Which package should own %_sysconfdir/X11/xinit/xinput.d ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review