[Bug 1422683] Review Request: dahdi-tools - Tools for Digium Asterisk Hardware Device Interface drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1422683



--- Comment #7 from Jared Smith <jsmith.fedora@xxxxxxxxx> ---
My most sincere apologies for the latency on this issue... I've been wholly
consumed with work (12+ hours per day) and some pressing personal/family issues
that have consumed the "free" time I typically use for contributing to projects
like Asterisk and Fedora. 


(In reply to Leif Madsen from comment #1)
> - All build dependencies are listed in BuildRequires, except for any that
>   are listed in the exceptions section of Packaging Guidelines.
>   Note: These BR are not needed: coreutils gcc sed make findutils
>   See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

Fixed in latest version listed below.

> - If (and only if) the source package includes the text of the license(s)
>   in its own file, then that file, containing the text of the license(s)
>   for the package is included in %license.
>   Note: License file astribank_license.c is not marked as %license
>   See:
>   http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

This is a false positive -- astribank_license.c is not an actual license file.

It looks like Leif dropped himself off from doing the review -- would anyone
else like to pick it up and finish the review so that we can un-retire this
package?

Spec URL:
https://jsmith.fedorapeople.org/Packaging/dahdi-tools/dahdi-tools.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/dahdi-tools/dahdi-tools-2.11.1-2.fc27.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux